stops infinite recursion. attempts to clarify difference between the 2 deploy requests #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2 deploy requests
jordan-rash
previously approved these changes
Aug 2, 2024
|
Could we rename to AgentRequest or AgentDeployRequest instead? |
At the point it becomes the agent workload info, it's no longer a request. It isn't something that can be rejected for validation reasons, etc, it's a command or, as it stands now, it's a standalone piece of info. Naming is hard. |
jordan-rash
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the minor fix, there's a few renames and the removal of unused properties. There is a lot more work to do on refactoring how we're using the internal agent deploy "command" and the external control deploy "request". What I've done here is just what can be done without having to rewrite any functions.